Welcome!

Final Burn Neo => FBN Discussion => Topic started by: spludlow on July 19, 2022, 05:04:01 AM

Title: Question marks in ROM filenames
Post by: spludlow on July 19, 2022, 05:04:01 AM

Hello

Megadrive   tecmocup   tecmo cup (jpn) (prototype?) (bad dump).bin   524288   88FDD060

This seems to be the only filename in the whole of FBNeo with an illegal (at least in my OS) filename. Been in there for a while.

It causes me grief. Can it be fixed?

Cheers
Sam

Title: Re: Question marks in ROM filenames
Post by: barbudreadmon on July 19, 2022, 05:36:50 AM

What's your OS ? I don't think that's the only question mark in our codebase

Title: Re: Question marks in ROM filenames
Post by: spludlow on July 19, 2022, 07:35:24 AM

Hello

My OS is Windows, all I mean is ? is not a legal filename, might be able to do it on macOS or something?

It is currently the only rom.name that can't be saved to a file (that matches the data).

(I've got the XML in a DB)
select * from rom where name like '%?%'

137516   10926   tecmo cup (jpn) (prototype?) (bad dump).bin   524288   88fdd060   NULL   NULL

There may be ? in game.description but that don't need to be on the file system as game.name is the ZIP filename.

Cheers
Sam

Title: Re: Question marks in ROM filenames
Post by: spludlow on July 19, 2022, 08:02:33 AM

Nice one barbudreadmon I see its fixed.

Cheers
Sam

Title: Re: Question marks in ROM filenames
Post by: Robert on July 19, 2022, 09:16:50 PM

? represents a one-character wildcard in windows, and so it's not allowed in filenames.