Author Topic: Best way to contribute to source code  (Read 4441 times)

Offline tokuio8752

  • Newbies
  • *
  • Posts: 12
  • Karma: +0/-0
Best way to contribute to source code
« on: August 20, 2019, 01:44:59 PM »
Quite a while ago I posted this query https://neo-source.com/index.php?topic=3279.0 which was unresolved. Recently I had another look at this and wrote some code to solve the problem. What would be the best way to possibly get this added to the fb neo source?

I was thinking of forking the github repo and submitting a pull request, would this be the recommended way?

Thanks.

Offline iq_132

  • Administrator
  • *****
  • Posts: 3728
  • Karma: +411/-0
  • Definitely not Dink!
    • NeoSource
Re: Best way to contribute to source code
« Reply #1 on: August 20, 2019, 02:40:29 PM »
Quite a while ago I posted this query https://neo-source.com/index.php?topic=3279.0 which was unresolved. Recently I had another look at this and wrote some code to solve the problem. What would be the best way to possibly get this added to the fb neo source?

I was thinking of forking the github repo and submitting a pull request, would this be the recommended way?

Thanks.

That'd be great! You can also post the changes here if they are simple (a few lines). Or contact myself or Dink via pm.


Offline dink

  • Administrator
  • *****
  • Posts: 5014
  • Karma: +449/-1
  • pie? I nearly bought one!
Re: Best way to contribute to source code
« Reply #2 on: August 20, 2019, 10:54:31 PM »
Awesome :)
Submit it how you want: here, pm, pull request, its up to you.

best regards,
- dink

Offline tokuio8752

  • Newbies
  • *
  • Posts: 12
  • Karma: +0/-0
Re: Best way to contribute to source code
« Reply #3 on: August 21, 2019, 06:55:52 AM »
Cool, thanks

Offline dink

  • Administrator
  • *****
  • Posts: 5014
  • Karma: +449/-1
  • pie? I nearly bought one!
Re: Best way to contribute to source code
« Reply #4 on: August 25, 2019, 09:23:23 AM »
Very nicely done, thanks for the contribution! :)