Author Topic: -- High Score saving! --  (Read 6941 times)

Offline Riddler

  • New Member
  • *
  • Posts: 8
  • Karma: +0/-0
Re: -- High Score saving! --
« Reply #15 on: January 02, 2019, 09:53:03 AM »
Hi I'm new. I edited the d_neogeo.cpp and compiled my own version of FBA for testing as i want to get more hiscore support for Neo Geo. I have tested and confirm that hiscores are work for the following games: -

Cyberlip
G Pilots
Last Resort
Metal Slug X
Nam 1975

https://github.com/Riddler1/fbalpha2018/blob/master/src/burn/drv/neogeo/d_neogeo.cpp




Offline dink

  • Administrator
  • *****
  • Posts: 3824
  • Karma: +325/-0
  • pie? I nearly bought one!
Re: -- High Score saving! --
« Reply #16 on: January 02, 2019, 10:06:06 PM »
Thanks, I've updated updated d_neogeo.cpp with the changes :)

Offline Riddler

  • New Member
  • *
  • Posts: 8
  • Karma: +0/-0
Re: -- High Score saving! --
« Reply #17 on: October 21, 2020, 10:40:08 AM »
Hello,

i have tested and made some updates to the 5 hiscores files below for your approval.

d_sys16a,cpp
d_sys18.cpp
d_sys16b.cpp
d_fuukifg3.cpp
d_legionna.cpp


https://github.com/Riddler1/FBNeo/commits/master


Offline barbudreadmon

  • Administrator
  • *****
  • Posts: 637
  • Karma: +27/-1
  • Helper
Re: -- High Score saving! --
« Reply #18 on: October 21, 2020, 12:40:55 PM »
d_fuukifg3.cpp
d_legionna.cpp

There is definitely something abnormal about those 2 saving hiscores with your changes since HiscoreReset isn't called. If hiscores are somehow saved for those systems, it means it's saved in nvram and the BDF_HISCORE_SUPPORTED is not needed.

Offline dink

  • Administrator
  • *****
  • Posts: 3824
  • Karma: +325/-0
  • pie? I nearly bought one!
Re: -- High Score saving! --
« Reply #19 on: October 21, 2020, 08:10:44 PM »
Riddler, thanks, please add "HiscoreReset();" to the reset handlers in the 2 drivers that barbudreadmon listed and submit the pr :)

best regards,
- dink

Offline Riddler

  • New Member
  • *
  • Posts: 8
  • Karma: +0/-0
Re: -- High Score saving! --
« Reply #20 on: October 23, 2020, 11:16:33 AM »
Yes, thanks all done

Offline barbudreadmon

  • Administrator
  • *****
  • Posts: 637
  • Karma: +27/-1
  • Helper
Re: -- High Score saving! --
« Reply #21 on: October 23, 2020, 11:30:46 AM »
Please replace those whitespaces before HiscoreReset by tabs, and we should be ok to merge

Offline Riddler

  • New Member
  • *
  • Posts: 8
  • Karma: +0/-0
Re: -- High Score saving! --
« Reply #22 on: October 23, 2020, 02:56:36 PM »
Doh, sorry. all done